From: Andreas Schneider Date: Wed, 10 Jun 2020 15:38:36 +0000 (+0200) Subject: s3:rpc_server: Check return code of set_blocking() X-Git-Tag: ldb-2.2.0~102 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9b34cee610892a9241dd7128f5ee5f9e99029e92;p=thirdparty%2Fsamba.git s3:rpc_server: Check return code of set_blocking() Found by Coverity. Signed-off-by: Andreas Schneider Reviewed-by: Isaac Boukris --- diff --git a/source3/rpc_server/rpc_server.c b/source3/rpc_server/rpc_server.c index 4037c81cfc8..9e57bc34559 100644 --- a/source3/rpc_server/rpc_server.c +++ b/source3/rpc_server/rpc_server.c @@ -382,7 +382,11 @@ NTSTATUS dcesrv_setup_ncacn_ip_tcp_socket(struct tevent_context *ev_ctx, set_socket_options(state->fd, lp_socket_options()); /* Set server socket to non-blocking for the accept. */ - set_blocking(state->fd, false); + rc = set_blocking(state->fd, false); + if (rc < 0) { + status = map_nt_error_from_unix_common(errno); + goto out; + } rc = listen(state->fd, SMBD_LISTEN_BACKLOG); if (rc == -1) { @@ -612,7 +616,11 @@ NTSTATUS dcesrv_setup_ncalrpc_socket(struct tevent_context *ev_ctx, } /* Set server socket to non-blocking for the accept. */ - set_blocking(state->fd, false); + rc = set_blocking(state->fd, false); + if (rc < 0) { + status = map_nt_error_from_unix_common(errno); + goto out; + } errno = 0; fde = tevent_add_fd(state->ev_ctx,