From: Tamir Duberstein <tamird@kernel.org>
Date: Tue, 27 Jan 2026 16:35:43 +0000 (-0500)
Subject: scripts: generate_rust_analyzer.py: avoid FD leak
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9b4744d8eda2824041064a5639ccbb079850914d;p=thirdparty%2Fkernel%2Flinux.git

scripts: generate_rust_analyzer.py: avoid FD leak

Use `pathlib.Path.read_text()` to avoid leaking file descriptors.

Fixes: 8c4555ccc55c ("scripts: add `generate_rust_analyzer.py`")
Cc: stable@vger.kernel.org
Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com>
Reviewed-by: Fiona Behrens <me@kloenk.dev>
Reviewed-by: Trevor Gross <tmgross@umich.edu>
Link: https://patch.msgid.link/20260127-rust-analyzer-fd-leak-v2-1-1bb55b9b6822@kernel.org
Signed-off-by: Tamir Duberstein <tamird@kernel.org>
---

diff --git a/scripts/generate_rust_analyzer.py b/scripts/generate_rust_analyzer.py
index 38e834bd209e0..024e71a742e08 100755
--- a/scripts/generate_rust_analyzer.py
+++ b/scripts/generate_rust_analyzer.py
@@ -313,9 +313,10 @@ def generate_crates(
 
     def is_root_crate(build_file: pathlib.Path, target: str) -> bool:
         try:
-            return f"{target}.o" in open(build_file).read()
+            contents = build_file.read_text()
         except FileNotFoundError:
             return False
+        return f"{target}.o" in contents
 
     # Then, the rest outside of `rust/`.
     #