From: Rob van der Linde <rob@catalyst.net.nz>
Date: Thu, 27 Jul 2023 04:31:01 +0000 (+1200)
Subject: netcmd: user: move user password command
X-Git-Tag: tevent-0.16.0~1267
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9b47a4243378369ee75102b536df60d4d087dcd8;p=thirdparty%2Fsamba.git

netcmd: user: move user password command

Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/python/samba/netcmd/user/__init__.py b/python/samba/netcmd/user/__init__.py
index 09d7362f893..e3576f1cad3 100644
--- a/python/samba/netcmd/user/__init__.py
+++ b/python/samba/netcmd/user/__init__.py
@@ -38,7 +38,6 @@ from samba import (
     generate_random_password,
     Ldb,
 )
-from samba.net import Net
 
 from samba.netcmd import (
     Command,
@@ -63,56 +62,10 @@ from .delete import cmd_user_delete
 from .disable import cmd_user_disable
 from .enable import cmd_user_enable
 from .list import cmd_user_list
+from .password import cmd_user_password
 from .setexpiry import cmd_user_setexpiry
 
 
-class cmd_user_password(Command):
-    """Change password for a user account (the one provided in authentication).
-"""
-
-    synopsis = "%prog [options]"
-
-    takes_options = [
-        Option("--newpassword", help="New password", type=str),
-    ]
-
-    takes_optiongroups = {
-        "sambaopts": options.SambaOptions,
-        "credopts": options.CredentialsOptions,
-        "versionopts": options.VersionOptions,
-    }
-
-    def run(self, credopts=None, sambaopts=None, versionopts=None,
-            newpassword=None):
-
-        lp = sambaopts.get_loadparm()
-        creds = credopts.get_credentials(lp)
-
-        # get old password now, to get the password prompts in the right order
-        old_password = creds.get_password()
-
-        net = Net(creds, lp, server=credopts.ipaddress)
-
-        password = newpassword
-        while True:
-            if password is not None and password != '':
-                break
-            password = getpass("New Password: ")
-            passwordverify = getpass("Retype Password: ")
-            if not password == passwordverify:
-                password = None
-                self.outf.write("Sorry, passwords do not match.\n")
-
-        try:
-            if not isinstance(password, str):
-                password = password.decode('utf8')
-            net.change_password(password)
-        except Exception as msg:
-            # FIXME: catch more specific exception
-            raise CommandError("Failed to change password : %s" % msg)
-        self.outf.write("Changed password OK\n")
-
-
 class cmd_user_getgroups(Command):
     """Get the direct group memberships of a user account.
 
diff --git a/python/samba/netcmd/user/password.py b/python/samba/netcmd/user/password.py
new file mode 100644
index 00000000000..3b26b62000d
--- /dev/null
+++ b/python/samba/netcmd/user/password.py
@@ -0,0 +1,73 @@
+# user management
+#
+# user password
+#
+# Copyright Jelmer Vernooij 2010 <jelmer@samba.org>
+# Copyright Theresa Halloran 2011 <theresahalloran@gmail.com>
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+
+from getpass import getpass
+
+import samba.getopt as options
+from samba.net import Net
+from samba.netcmd import Command, CommandError, Option
+
+
+class cmd_user_password(Command):
+    """Change password for a user account (the one provided in authentication).
+"""
+
+    synopsis = "%prog [options]"
+
+    takes_options = [
+        Option("--newpassword", help="New password", type=str),
+    ]
+
+    takes_optiongroups = {
+        "sambaopts": options.SambaOptions,
+        "credopts": options.CredentialsOptions,
+        "versionopts": options.VersionOptions,
+    }
+
+    def run(self, credopts=None, sambaopts=None, versionopts=None,
+            newpassword=None):
+
+        lp = sambaopts.get_loadparm()
+        creds = credopts.get_credentials(lp)
+
+        # get old password now, to get the password prompts in the right order
+        old_password = creds.get_password()
+
+        net = Net(creds, lp, server=credopts.ipaddress)
+
+        password = newpassword
+        while True:
+            if password is not None and password != '':
+                break
+            password = getpass("New Password: ")
+            passwordverify = getpass("Retype Password: ")
+            if not password == passwordverify:
+                password = None
+                self.outf.write("Sorry, passwords do not match.\n")
+
+        try:
+            if not isinstance(password, str):
+                password = password.decode('utf8')
+            net.change_password(password)
+        except Exception as msg:
+            # FIXME: catch more specific exception
+            raise CommandError("Failed to change password : %s" % msg)
+        self.outf.write("Changed password OK\n")