From: Ondrej Zajicek (work) <santiago@crfreenet.org>
Date: Fri, 15 Mar 2019 19:57:26 +0000 (+0100)
Subject: BGP: Handle case where capabilites are not used
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9b73157ea174e65585547c4dbf7181fb0ae07cc5;p=thirdparty%2Fbird.git

BGP: Handle case where capabilites are not used

If peer does not announce capabilities at all, or when we have
capabilities disabled, handle that as implicit IPv4 unicast.
---

diff --git a/proto/bgp/bgp.c b/proto/bgp/bgp.c
index 1c6bbf238..6a6205f57 100644
--- a/proto/bgp/bgp.c
+++ b/proto/bgp/bgp.c
@@ -487,6 +487,7 @@ bgp_conn_enter_openconfirm_state(struct bgp_conn *conn)
 }
 
 static const struct bgp_af_caps dummy_af_caps = { };
+static const struct bgp_af_caps basic_af_caps = { .ready = 1 };
 
 void
 bgp_conn_enter_established_state(struct bgp_conn *conn)
@@ -530,6 +531,13 @@ bgp_conn_enter_established_state(struct bgp_conn *conn)
     const struct bgp_af_caps *loc = bgp_find_af_caps(local, c->afi);
     const struct bgp_af_caps *rem = bgp_find_af_caps(peer,  c->afi);
 
+    /* Use default if capabilities were not announced */
+    if (!local->length && (c->afi == BGP_AF_IPV4))
+      loc = &basic_af_caps;
+
+    if (!peer->length && (c->afi == BGP_AF_IPV4))
+      rem = &basic_af_caps;
+
     /* Ignore AFIs that were not announced in multiprotocol capability */
     if (!loc || !loc->ready)
       loc = &dummy_af_caps;
diff --git a/proto/bgp/bgp.h b/proto/bgp/bgp.h
index 8e7fe15e9..5e3b1e3f1 100644
--- a/proto/bgp/bgp.h
+++ b/proto/bgp/bgp.h
@@ -192,6 +192,7 @@ struct bgp_caps {
   u16 gr_time;				/* Graceful restart time in seconds */
 
   u16 af_count;				/* Number of af_data items */
+  u16 length;				/* Length of capabilities in OPEN msg */
 
   struct bgp_af_caps af_data[0];	/* Per-AF capability data */
 };
diff --git a/proto/bgp/packets.c b/proto/bgp/packets.c
index a0f8d9178..5c3c4c679 100644
--- a/proto/bgp/packets.c
+++ b/proto/bgp/packets.c
@@ -237,6 +237,7 @@ bgp_write_capabilities(struct bgp_conn *conn, byte *buf)
   struct bgp_af_caps *ac;
   uint any_ext_next_hop = 0;
   uint any_add_path = 0;
+  byte *buf_head = buf;
   byte *data;
 
   /* Prepare bgp_caps structure */
@@ -384,6 +385,8 @@ bgp_write_capabilities(struct bgp_conn *conn, byte *buf)
     *buf++ = 0;			/* Capability data length */
   }
 
+  caps->length = buf - buf_head;
+
   return buf;
 }
 
@@ -395,6 +398,8 @@ bgp_read_capabilities(struct bgp_conn *conn, struct bgp_caps *caps, byte *pos, i
   int i, cl;
   u32 af;
 
+  caps->length += len;
+
   while (len > 0)
   {
     if (len < 2 || len < (2 + pos[1]))