From: Alejandro Colomar <alx@kernel.org>
Date: Sat, 2 Sep 2023 13:24:06 +0000 (+0200)
Subject: lib/limits.c: Fix wrong error check
X-Git-Tag: 4.15.0-rc1~102
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9b798b584adb919368af65fb4dce4d072714cbf8;p=thirdparty%2Fshadow.git

lib/limits.c: Fix wrong error check

strtol(3) doesn't specify a return value if (value == endptr).
It is always an error, if (value==endptr).

Signed-off-by: Alejandro Colomar <alx@kernel.org>
---

diff --git a/lib/limits.c b/lib/limits.c
index efb24a546..b3ea1784e 100644
--- a/lib/limits.c
+++ b/lib/limits.c
@@ -62,7 +62,8 @@ static int setrlimit_value (unsigned int resource,
 		 */
 		char *endptr;
 		long longlimit = strtol (value, &endptr, 10);
-		if ((0 == longlimit) && (value == endptr)) {
+
+		if (value == endptr) {
 			/* No argument at all. No-op.
 			 * FIXME: We could instead throw an error, though.
 			 */