From: Rico Tzschichholz <ricotz@ubuntu.com>
Date: Sat, 6 Mar 2021 13:06:10 +0000 (+0100)
Subject: gdbus: Don't leak memory of deserialized arguments on error in wrapper method
X-Git-Tag: 0.51.90~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9b7b64716371bd1791a5c30666807314d79eacfc;p=thirdparty%2Fvala.git

gdbus: Don't leak memory of deserialized arguments on error in wrapper method

Found by -fsanitize=address
---

diff --git a/codegen/valagdbusservermodule.vala b/codegen/valagdbusservermodule.vala
index 06166772e..68ca2b7fb 100644
--- a/codegen/valagdbusservermodule.vala
+++ b/codegen/valagdbusservermodule.vala
@@ -193,6 +193,8 @@ public class Vala.GDBusServerModule : GDBusClientModule {
 					}
 
 					ccode.close ();
+				} else if (!need_goto_label && m.tree_can_fail && requires_destroy (owned_type)) {
+					need_goto_label = true;
 				}
 			}
 		}