From: Yohan BELLEGUIC <yohan.belleguic@diateam.net>
Date: Wed, 19 Nov 2014 08:53:15 +0000 (+0100)
Subject: vbox: fix a bug in _machineStateInactive
X-Git-Tag: CVE-2014-8135~122
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9b7e7e3474a7694e7dbee17e88008fa03e618c4a;p=thirdparty%2Flibvirt.git

vbox: fix a bug in _machineStateInactive

This function returned non-inactive domains instead of active
domains.  This broke virConnectNumOfDefinedDomains() and
virConnectListDefinedDomains() functions.
---

diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c
index de8744d5a0..37ec8e1c44 100644
--- a/src/vbox/vbox_tmpl.c
+++ b/src/vbox/vbox_tmpl.c
@@ -4607,8 +4607,8 @@ static bool _machineStateOnline(PRUint32 state)
 
 static bool _machineStateInactive(PRUint32 state)
 {
-    return ((state > MachineState_FirstOnline) &&
-            (state < MachineState_LastOnline));
+    return ((state < MachineState_FirstOnline) ||
+            (state > MachineState_LastOnline));
 }
 
 static bool _machineStateNotStart(PRUint32 state)