From: Andreas Schneider <asn@samba.org>
Date: Wed, 16 May 2018 09:53:05 +0000 (+0200)
Subject: s4:dsdb:tests: Add return code check
X-Git-Tag: ldb-1.4.0~202
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9b8f5616dbdd7fa593156e000398c00b16dcc84c;p=thirdparty%2Fsamba.git

s4:dsdb:tests: Add return code check

Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/dsdb/samdb/ldb_modules/tests/test_unique_object_sids.c b/source4/dsdb/samdb/ldb_modules/tests/test_unique_object_sids.c
index dfc6d49cfa7..f9065e4e489 100644
--- a/source4/dsdb/samdb/ldb_modules/tests/test_unique_object_sids.c
+++ b/source4/dsdb/samdb/ldb_modules/tests/test_unique_object_sids.c
@@ -405,11 +405,12 @@ static void test_modify_of_objectSID_replicated(void **state)
 	assert_non_null(request);
 	original_request = request;
 
-	ldb_request_add_control(
+	rc = ldb_request_add_control(
 		request,
 		DSDB_CONTROL_REPLICATED_UPDATE_OID,
 		false,
 		NULL);
+	assert_int_equal(rc, LDB_SUCCESS);
 
 	rc = unique_object_sids_modify(test_ctx->module, request);