From: Mark Andrews <marka@isc.org>
Date: Thu, 13 Aug 2020 00:51:40 +0000 (+1000)
Subject: SIG: reject records with a zero length signature
X-Git-Tag: v9.17.5~50^2~5
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9b93e5d68485469b704052c2997764891df7bff7;p=thirdparty%2Fbind9.git

SIG: reject records with a zero length signature
---

diff --git a/lib/dns/rdata/generic/sig_24.c b/lib/dns/rdata/generic/sig_24.c
index f4a237fe148..ff90631cc0b 100644
--- a/lib/dns/rdata/generic/sig_24.c
+++ b/lib/dns/rdata/generic/sig_24.c
@@ -274,6 +274,9 @@ fromwire_sig(ARGS_FROMWIRE) {
 	 * Sig.
 	 */
 	isc_buffer_activeregion(source, &sr);
+	if (sr.length == 0) {
+		return (ISC_R_UNEXPECTEDEND);
+	}
 	isc_buffer_forward(source, sr.length);
 	return (mem_tobuffer(target, sr.base, sr.length));
 }