From: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Date: Fri, 23 Dec 2011 13:44:28 +0000 (-0200)
Subject: tools: kmod: show wrong command in err message
X-Git-Tag: v3~91
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9b966da87ebf3b9482ba4d8a8727ae8087ae5b37;p=thirdparty%2Fkmod.git

tools: kmod: show wrong command in err message
---

diff --git a/tools/kmod.c b/tools/kmod.c
index 0aec4c36..ddd12e7d 100644
--- a/tools/kmod.c
+++ b/tools/kmod.c
@@ -113,26 +113,29 @@ static int handle_kmod_commands(int argc, char *argv[])
 	}
 
 	if (optind >= argc) {
-		err = -ENOENT;
-		goto finish;
+		fputs("missing command\n", stderr);
+		goto fail;
 	}
 
 	cmd = argv[optind];
 
-	for (i = 0; i < ARRAY_SIZE(kmod_cmds); i++) {
+	for (i = 0, err = -EINVAL; i < ARRAY_SIZE(kmod_cmds); i++) {
 		if (strcmp(kmod_cmds[i]->name, cmd) != 0)
 			continue;
 
 		err = kmod_cmds[i]->cmd(--argc, ++argv);
 	}
 
-finish:
 	if (err < 0) {
-		fputs("missing or unknown command\n", stderr);
-		kmod_help(argc, argv);
+		fprintf(stderr, "invalid command '%s'\n", cmd);
+		goto fail;
 	}
 
 	return err;
+
+fail:
+	kmod_help(argc, argv);
+	return EXIT_FAILURE;
 }