From: Amaury Denoyelle <adenoyelle@haproxy.com>
Date: Mon, 9 Aug 2021 13:09:17 +0000 (+0200)
Subject: BUG/MINOR: check: test if server is not null in purge
X-Git-Tag: v2.5-dev4~49
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9ba34ae710d28648242c07937c7ed875b3928263;p=thirdparty%2Fhaproxy.git

BUG/MINOR: check: test if server is not null in purge

Test if server is not null before using free_server in the check purge
operation. Currently, the null server scenario should not occured as
purge is used with refcounted dynamic servers. However, this might not
be always the case if purge is use in the future in other cases; thus
the test is useful for extensibility.

No need to backport, unless dynamic server checks are backported.

This has been reported through a coverity report in github issue #1343.
---

diff --git a/src/check.c b/src/check.c
index b49aca61a5..b1ffe5ecab 100644
--- a/src/check.c
+++ b/src/check.c
@@ -1253,7 +1253,8 @@ struct task *process_chk_conn(struct task *t, void *context, unsigned int state)
 		task_destroy(check->task);
 		t = NULL;
 
-		free_server(check->server);
+		if (check->server)
+			free_server(check->server);
 	}
 
 	return t;