From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Sun, 10 Jan 2016 22:36:07 +0000 (+1300)
Subject: asn1: make readContextSimple() add a NUL byte
X-Git-Tag: tdb-1.3.9~475
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9bbd7d1c77b63ead59e3abac29abca1e732d343c;p=thirdparty%2Fsamba.git

asn1: make readContextSimple() add a NUL byte

Pair-programmed-with: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
---

diff --git a/lib/util/asn1.c b/lib/util/asn1.c
index d81e50fd9be..d3b46aac857 100644
--- a/lib/util/asn1.c
+++ b/lib/util/asn1.c
@@ -938,12 +938,14 @@ bool asn1_read_ContextSimple(struct asn1_data *data, TALLOC_CTX *mem_ctx, uint8_
 		data->has_error = true;
 		return false;
 	}
-	*blob = data_blob_talloc(mem_ctx, NULL, len);
+	*blob = data_blob_talloc(mem_ctx, NULL, len + 1);
 	if ((len != 0) && (!blob->data)) {
 		data->has_error = true;
 		return false;
 	}
 	if (!asn1_read(data, blob->data, len)) return false;
+	blob->length--;
+	blob->data[len] = 0;
 	return asn1_end_tag(data);
 }