From: Masahiro Yamada Date: Wed, 15 Jul 2015 01:29:00 +0000 (+0900) Subject: devres: fix devres_get() X-Git-Tag: v2.6.32.69~26 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9bc0d0094ad62c1b6f957e1e148c08f3df3adc81;p=thirdparty%2Fkernel%2Fstable.git devres: fix devres_get() commit 64526370d11ce8868ca495723d595b61e8697fbf upstream. Currently, devres_get() passes devres_free() the pointer to devres, but devres_free() should be given with the pointer to resource data. Fixes: 9ac7849e35f7 ("devres: device resource management") Signed-off-by: Masahiro Yamada Acked-by: Tejun Heo Signed-off-by: Greg Kroah-Hartman Signed-off-by: Ben Hutchings (cherry picked from commit ebc0ae5a7159086a992f7904dc9ad849a13eecfc) Signed-off-by: Willy Tarreau --- diff --git a/drivers/base/devres.c b/drivers/base/devres.c index 05dd307e8f024..6d022dc77b799 100644 --- a/drivers/base/devres.c +++ b/drivers/base/devres.c @@ -253,10 +253,10 @@ void * devres_get(struct device *dev, void *new_res, if (!dr) { add_dr(dev, &new_dr->node); dr = new_dr; - new_dr = NULL; + new_res = NULL; } spin_unlock_irqrestore(&dev->devres_lock, flags); - devres_free(new_dr); + devres_free(new_res); return dr->data; }