From: Nick Mathewson <nickm@torproject.org>
Date: Wed, 18 Nov 2009 16:26:44 +0000 (-0500)
Subject: Not everybody likes debugging printfs as much as I
X-Git-Tag: tor-0.2.2.6-alpha~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9be682942c14112c5af63e866d33558c45d609c9;p=thirdparty%2Ftor.git

Not everybody likes debugging printfs as much as I
---

diff --git a/src/or/dirvote.c b/src/or/dirvote.c
index 448c1270cd..f745db6fc4 100644
--- a/src/or/dirvote.c
+++ b/src/or/dirvote.c
@@ -1417,26 +1417,22 @@ networkstatus_add_detached_signatures(networkstatus_t *target,
 
   /* Do the times seem right? */
   if (target->valid_after != sigs->valid_after) {
-    puts("A");
     *msg_out = "Valid-After times do not match "
       "when adding detached signatures to consensus";
     return -1;
   }
   if (target->fresh_until != sigs->fresh_until) {
-    puts("B");
     *msg_out = "Fresh-until times do not match "
       "when adding detached signatures to consensus";
     return -1;
   }
   if (target->valid_until != sigs->valid_until) {
-    puts("C");
     *msg_out = "Valid-until times do not match "
       "when adding detached signatures to consensus";
     return -1;
   }
   siglist = strmap_get(sigs->signatures, flavor);
   if (!siglist) {
-    puts("D");
     *msg_out = "No signatures for given consensus flavor";
     return -1;
   }
@@ -1447,7 +1443,6 @@ networkstatus_add_detached_signatures(networkstatus_t *target,
     int n_matches = 0;
     digest_algorithm_t alg;
     if (!digests) {
-      puts("D");
       *msg_out = "No digests for given consensus flavor";
       return -1;
     }
@@ -1456,16 +1451,12 @@ networkstatus_add_detached_signatures(networkstatus_t *target,
         if (!memcmp(target->digests.d[alg], digests->d[alg], DIGEST256_LEN)) {
           ++n_matches;
         } else {
-          printf("F %d\n", alg);
-          printf("%s\n", hex_str(target->digests.d[alg], DIGEST256_LEN));
-          printf("%s\n", hex_str(digests->d[alg], DIGEST256_LEN));
           *msg_out = "Mismatched digest.";
           return -1;
         }
       }
     }
     if (!n_matches) {
-      puts("G");
       *msg_out = "No regognized digests for given consensus flavor";
     }
   }