From: Aurelien DARRAGON <adarragon@haproxy.com>
Date: Thu, 1 Jun 2023 08:58:44 +0000 (+0200)
Subject: BUG/MINOR: proxy: add missing interface bind free in free_proxy
X-Git-Tag: v2.9-dev1~65
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9be9225ef288d707ba8e446c77ff822a521cbb4e;p=thirdparty%2Fhaproxy.git

BUG/MINOR: proxy: add missing interface bind free in free_proxy

bind->settings.interface hint is allocated when "interface" keyword
is specified on a bind line, but the string isn't explicitly freed in
proxy_free, resulting in minor memory leak on deinit paths when the
keyword is being used.

It partially fixes GH #2173 and may be backported to all stable versions.

[in 2.2 free_proxy did not exist so the patch must be applied directly
in deinit() function from haproxy.c]
---

diff --git a/src/proxy.c b/src/proxy.c
index b932c0c2bd..bc086865c0 100644
--- a/src/proxy.c
+++ b/src/proxy.c
@@ -327,6 +327,7 @@ void free_proxy(struct proxy *p)
 			bind_conf->xprt->destroy_bind_conf(bind_conf);
 		free(bind_conf->file);
 		free(bind_conf->arg);
+		free(bind_conf->settings.interface);
 		LIST_DELETE(&bind_conf->by_fe);
 		free(bind_conf);
 	}