From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 17 May 2022 08:32:47 +0000 (+0200)
Subject: qemuFDPassValidate: Don't validate file descriptors
X-Git-Tag: v8.4.0-rc1~131
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9bed5604db580bcb86c1dea6dae17ea8342a4125;p=thirdparty%2Flibvirt.git

qemuFDPassValidate: Don't validate file descriptors

The callers adding the FDs are validating them regardless so this check
was redundant.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/qemu/qemu_fd.c b/src/qemu/qemu_fd.c
index baa16fd669..3b4c069080 100644
--- a/src/qemu/qemu_fd.c
+++ b/src/qemu/qemu_fd.c
@@ -68,8 +68,6 @@ qemuFDPassFree(qemuFDPass *fdpass)
 static int
 qemuFDPassValidate(qemuFDPass *fdpass)
 {
-    size_t i;
-
     if (!fdpass->useFDSet &&
         fdpass->nfds > 1) {
         virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
@@ -77,14 +75,6 @@ qemuFDPassValidate(qemuFDPass *fdpass)
         return -1;
     }
 
-    for (i = 0; i < fdpass->nfds; i++) {
-        if (fdpass->fds[i].fd < 0) {
-            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
-                           _("invalid file descriptor"));
-            return -1;
-        }
-    }
-
     return 0;
 }