From: Xiang Zhang Date: Wed, 22 Mar 2017 06:32:52 +0000 (+0800) Subject: bpo-29876: fix DECREF for NULL value in subelement() (GH-760) X-Git-Tag: v2.7.14rc1~240 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9c0408d9b68d8f65aad22ca0767f154d6b9f526c;p=thirdparty%2FPython%2Fcpython.git bpo-29876: fix DECREF for NULL value in subelement() (GH-760) --- diff --git a/Modules/_elementtree.c b/Modules/_elementtree.c index 7a0aeda63cf3..94dc5b7ca35e 100644 --- a/Modules/_elementtree.c +++ b/Modules/_elementtree.c @@ -524,8 +524,9 @@ subelement(PyObject* self, PyObject* args, PyObject* kw) } elem = element_new(tag, attrib); - Py_DECREF(attrib); + if (elem == NULL) + return NULL; if (element_add_subelement(parent, elem) < 0) { Py_DECREF(elem);