From: Michael R Sweet <michael.r.sweet@gmail.com>
Date: Tue, 16 Jul 2019 14:37:37 +0000 (-0400)
Subject: Log held job messages as errors so that is it clear why a job was held (Issue #5604)
X-Git-Tag: v2.3.0~29
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9c13b7d26e1652a8267a96ab9af9f0527a908616;p=thirdparty%2Fcups.git

Log held job messages as errors so that is it clear why a job was held (Issue #5604)
---

diff --git a/scheduler/job.c b/scheduler/job.c
index 4e8990fe52..89b1c28c58 100644
--- a/scheduler/job.c
+++ b/scheduler/job.c
@@ -2625,7 +2625,7 @@ cupsdSetJobState(
     else
       cupsdAddEvent(CUPSD_EVENT_JOB_STATE, job->printer, job, "%s", buffer);
 
-    if (newstate == IPP_JOB_STOPPED || newstate == IPP_JOB_ABORTED)
+    if (newstate == IPP_JOB_STOPPED || newstate == IPP_JOB_ABORTED || newstate == IPP_JOB_HELD)
       cupsdLogJob(job, CUPSD_LOG_ERROR, "%s", buffer);
     else
       cupsdLogJob(job, CUPSD_LOG_INFO, "%s", buffer);