From: Michael Brown <mcb30@ipxe.org>
Date: Tue, 21 Jul 2015 13:51:16 +0000 (+0100)
Subject: [netdevice] Avoid using zero as a network device index
X-Git-Tag: v1.20.1~758
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9c185e2eac39561c2e9847c355c5b710c3e557b5;p=thirdparty%2Fipxe.git

[netdevice] Avoid using zero as a network device index

Avoid using zero as a network device index, so that a zero
sin6_scope_id can be used to mean "unspecified" (rather than
unintentionally meaning "net0").

Signed-off-by: Michael Brown <mcb30@ipxe.org>
---

diff --git a/src/net/netdevice.c b/src/net/netdevice.c
index 889b00c1a..7c40a2ac8 100644
--- a/src/net/netdevice.c
+++ b/src/net/netdevice.c
@@ -676,11 +676,11 @@ int register_netdev ( struct net_device *netdev ) {
 	}
 
 	/* Record device index and create device name */
-	netdev->index = netdev_index++;
 	if ( netdev->name[0] == '\0' ) {
 		snprintf ( netdev->name, sizeof ( netdev->name ), "net%d",
-			   netdev->index );
+			   netdev_index );
 	}
+	netdev->index = ++netdev_index;
 
 	/* Use least significant bits of the link-layer address to
 	 * improve the randomness of the (non-cryptographic) random