From: Eric Sandeen <sandeen@redhat.com>
Date: Mon, 15 Sep 2014 23:19:37 +0000 (+1000)
Subject: xfs_db: free flist on error in write_struct()
X-Git-Tag: v3.2.2~20
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9c1c2e3257199a115b72154c856d8c62e76fca46;p=thirdparty%2Fxfsprogs-dev.git

xfs_db: free flist on error in write_struct()

One error path in write_struct() wasn't freeing the flist_t *fl
which was allocated, so it leaks.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
---

diff --git a/db/write.c b/db/write.c
index 0157a44ff..a0f14f46e 100644
--- a/db/write.c
+++ b/db/write.c
@@ -652,6 +652,7 @@ write_struct(
 	buf = convert_arg(argv[1], bit_length);
 	if (!buf) {
 		dbprintf(_("unable to convert value '%s'.\n"), argv[1]);
+		flist_free(fl);
 		return;
 	}