From: Jeremy Sowden <jeremy@azazel.net>
Date: Sun, 25 Oct 2020 13:15:50 +0000 (+0100)
Subject: pknlusr: tidy up initialization of local address
X-Git-Tag: v3.12~18
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9cd0b44c81b500fcf87a8b3f1337bfedc20a4305;p=thirdparty%2Fxtables-addons.git

pknlusr: tidy up initialization of local address

Use struct initialization and drop memset. We do not need to set the port
ID, since the kernel will do it for us.

Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
---

diff --git a/extensions/pknock/pknlusr.c b/extensions/pknock/pknlusr.c
index 71341cf..b53dc64 100644
--- a/extensions/pknock/pknlusr.c
+++ b/extensions/pknock/pknlusr.c
@@ -16,7 +16,7 @@ int main(void)
 {
 	int status;
 	int group = GROUP;
-	struct sockaddr_nl local_addr;
+	struct sockaddr_nl local_addr = {.nl_family = AF_NETLINK};
 	int sock_fd, buf_size;
 	unsigned char *buf;
 
@@ -27,9 +27,6 @@ int main(void)
 		return 1;
 	}
 
-	memset(&local_addr, 0, sizeof(local_addr));
-	local_addr.nl_family = AF_NETLINK;
-	local_addr.nl_pid = getpid();
 	local_addr.nl_groups = group;
 	status = bind(sock_fd, (struct sockaddr *)&local_addr, sizeof(local_addr));
 	if (status == -1) {