From: Andrew Bartlett <abartlet@samba.org>
Date: Fri, 13 Oct 2006 07:25:51 +0000 (+0000)
Subject: r19261: Fix use of unitialised variables.  (The binding string is used, if not
X-Git-Tag: samba-4.0.0alpha6~801^3~4515
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9ce0de670bc3a19a189fe45442b929ad0f2ec3b5;p=thirdparty%2Fsamba.git

r19261: Fix use of unitialised variables.  (The binding string is used, if not
NULL).

This showed up in a manual pre-TP3 test of the 'net samdump' code, and
shows the critical need for the windows testing infrustructure on the
build farm.

Andrew Bartlett
(This used to be commit 9cef40779ad987b506b1f514a67b5b1c8aea9969)
---

diff --git a/source4/libnet/libnet_join.c b/source4/libnet/libnet_join.c
index 14e3e5b719d..5781bc19c28 100644
--- a/source4/libnet/libnet_join.c
+++ b/source4/libnet/libnet_join.c
@@ -460,9 +460,11 @@ NTSTATUS libnet_JoinDomain(struct libnet_context *ctx, TALLOC_CTX *mem_ctx, stru
 
 	/* prepare connect to the LSA pipe of PDC */
 	if (r->in.level == LIBNET_JOINDOMAIN_AUTOMATIC) {
+		connect_with_info->in.binding = NULL;
 		connect_with_info->in.name    = r->in.domain_name;
 	} else {
 		connect_with_info->in.binding = r->in.binding;
+		connect_with_info->in.name    = NULL;
 	}
 
 	connect_with_info->level              = LIBNET_RPC_CONNECT_DC_INFO;
diff --git a/source4/libnet/libnet_vampire.c b/source4/libnet/libnet_vampire.c
index 7421f8943c5..f5a326c676d 100644
--- a/source4/libnet/libnet_vampire.c
+++ b/source4/libnet/libnet_vampire.c
@@ -202,8 +202,9 @@ NTSTATUS libnet_SamSync_netlogon(struct libnet_context *ctx, TALLOC_CTX *mem_ctx
 	c->level              = LIBNET_RPC_CONNECT_DC_INFO;
 	if (r->in.binding_string) {
 		c->in.binding = r->in.binding_string;
-
+		c->in.name    = NULL;
 	} else {
+		c->in.binding = NULL;
 		c->in.name    = cli_credentials_get_domain(machine_account);
 	}