From: Ondřej Surý <ondrej@sury.org>
Date: Tue, 23 Jul 2019 14:24:32 +0000 (-0400)
Subject: Improve code style when checking old references values
X-Git-Tag: v9.15.8~10^2~10
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9ce3254a1b1ff583970ec7cc8f6dc82384dbcb0b;p=thirdparty%2Fbind9.git

Improve code style when checking old references values
---

diff --git a/lib/dns/zt.c b/lib/dns/zt.c
index 5b410b18316..43120c75d4b 100644
--- a/lib/dns/zt.c
+++ b/lib/dns/zt.c
@@ -371,15 +371,12 @@ asyncload(dns_zone_t *zone, void *zt_) {
 	result = dns_zone_asyncload(zone, zt->loadparams->newonly,
 				    *zt->loadparams->dl, zt);
 	if (result != ISC_R_SUCCESS) {
-		uint_fast32_t oldref;
 		/*
 		 * Caller is holding a reference to zt->loads_pending
 		 * and zt->references so these can't decrement to zero.
 		 */
-		oldref = isc_refcount_decrement(&zt->loads_pending);
-		INSIST(oldref > 1);
-		oldref = isc_refcount_decrement(&zt->references);
-		INSIST(oldref > 1);
+		INSIST(isc_refcount_decrement(&zt->loads_pending) > 1);
+		INSIST(isc_refcount_decrement(&zt->references) > 1);
 	}
 	return (ISC_R_SUCCESS);
 }