From: Daniel Schultz Date: Mon, 24 Nov 2025 08:25:05 +0000 (-0800) Subject: board: phytec: phytec_som_detection: Add missing assignment X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9ce3d264e3b79b91d997eaa89dcd51488259c2b9;p=thirdparty%2Fu-boot.git board: phytec: phytec_som_detection: Add missing assignment Assign the return value of snprintf (total length) to a variable to properly check if the string has the correct length. Currently, this variable is always zero and the length check after snprintf will always fail. Signed-off-by: Daniel Schultz --- diff --git a/board/phytec/common/phytec_som_detection.c b/board/phytec/common/phytec_som_detection.c index 136f4486eb0..ff1711c24b4 100644 --- a/board/phytec/common/phytec_som_detection.c +++ b/board/phytec/common/phytec_som_detection.c @@ -346,8 +346,8 @@ static int phytec_get_part_number(struct phytec_eeprom_data *data, return 0; } if (api2->som_type <= 3) { - snprintf(part, PHYTEC_PART_NUMBER_MAX_LEN + 1, "%s.%s", - product_name, api2->bom_rev); + len = snprintf(part, PHYTEC_PART_NUMBER_MAX_LEN + 1, "%s.%s", + product_name, api2->bom_rev); if (len != PHYTEC_PART_NUMBER_KSP_LEN) return -EINVAL; return 0;