From: Stefan Metzmacher <metze@samba.org>
Date: Tue, 11 Feb 2025 21:27:04 +0000 (+0100)
Subject: libcli/lsarpc: change logic in trust_forest_record_to_lsa() to avoid default:
X-Git-Tag: tevent-0.17.0~706
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9cf4731afbabf0f6f6552ed6e039adf32c027e0e;p=thirdparty%2Fsamba.git

libcli/lsarpc: change logic in trust_forest_record_to_lsa() to avoid default:

We should let the compiler warn us if a enum type is missing.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/libcli/lsarpc/util_lsarpc.c b/libcli/lsarpc/util_lsarpc.c
index 4ac479f7970..7464ab6f34e 100644
--- a/libcli/lsarpc/util_lsarpc.c
+++ b/libcli/lsarpc/util_lsarpc.c
@@ -498,10 +498,11 @@ static NTSTATUS trust_forest_record_to_lsa(TALLOC_CTX *mem_ctx,
 
 	lftr->flags = ftr->flags;
 	lftr->time = ftr->timestamp;
-	lftr->type = (enum lsa_ForestTrustRecordType)ftr->type;
 
-	switch (lftr->type) {
-	case LSA_FOREST_TRUST_TOP_LEVEL_NAME:
+	switch (ftr->type) {
+	case FOREST_TRUST_TOP_LEVEL_NAME:
+		lftr->type = LSA_FOREST_TRUST_TOP_LEVEL_NAME;
+
 		lstr = &lftr->forest_trust_data.top_level_name;
 		str = &ftr->data.name;
 
@@ -511,9 +512,12 @@ static NTSTATUS trust_forest_record_to_lsa(TALLOC_CTX *mem_ctx,
 			return NT_STATUS_NO_MEMORY;
 		}
 
-		break;
+		*_lftr = lftr;
+		return NT_STATUS_OK;
+
+	case FOREST_TRUST_TOP_LEVEL_NAME_EX:
+		lftr->type = LSA_FOREST_TRUST_TOP_LEVEL_NAME_EX;
 
-	case LSA_FOREST_TRUST_TOP_LEVEL_NAME_EX:
 		lstr = &lftr->forest_trust_data.top_level_name_ex;
 		str = &ftr->data.name;
 
@@ -523,9 +527,12 @@ static NTSTATUS trust_forest_record_to_lsa(TALLOC_CTX *mem_ctx,
 			return NT_STATUS_NO_MEMORY;
 		}
 
-		break;
+		*_lftr = lftr;
+		return NT_STATUS_OK;
+
+	case FOREST_TRUST_DOMAIN_INFO:
+		lftr->type = LSA_FOREST_TRUST_DOMAIN_INFO;
 
-	case LSA_FOREST_TRUST_DOMAIN_INFO:
 		linfo = &lftr->forest_trust_data.domain_info;
 		info = &ftr->data.info;
 
@@ -551,14 +558,16 @@ static NTSTATUS trust_forest_record_to_lsa(TALLOC_CTX *mem_ctx,
 			return NT_STATUS_NO_MEMORY;
 		}
 
-		break;
+		*_lftr = lftr;
+		return NT_STATUS_OK;
 
-	default:
-		return NT_STATUS_NOT_SUPPORTED;
+	case FOREST_TRUST_BINARY_DATA:
+	case FOREST_TRUST_SCANNER_INFO:
+		/* TODO */
+		break;
 	}
 
-	*_lftr = lftr;
-	return NT_STATUS_OK;
+	return NT_STATUS_NOT_SUPPORTED;
 }
 
 NTSTATUS trust_forest_info_to_lsa(TALLOC_CTX *mem_ctx,