From: Zheng Liu <wenqing.lz@taobao.com>
Date: Sun, 13 Jan 2013 09:08:13 +0000 (+0800)
Subject: mke2fs: require the bigalloc feature explicity if the cluster size is set
X-Git-Tag: v1.42.7~31
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9cf69bb825c2995352502f48ea64d1be1d263995;p=thirdparty%2Fe2fsprogs.git

mke2fs: require the bigalloc feature explicity if the cluster size is set

When cluster-size is specified without the bigalloc feature, mke2fs
will ignore this argument silently.  But user might think bigalloc
feature has been enabled unless they use the dumpe2fs command.  So now
we ask user to set bigalloc feature explicity when cluster-size is
enabled.  This can make sure that users understand what they are doing
because bigalloc might impact the performance for some workloads.

Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---

diff --git a/misc/mke2fs.c b/misc/mke2fs.c
index 32b4c34e5..4748f4ab6 100644
--- a/misc/mke2fs.c
+++ b/misc/mke2fs.c
@@ -1847,6 +1847,11 @@ profile_error:
 							    blocksize*16);
 		fs_param.s_log_cluster_size =
 			int_log2(cluster_size >> EXT2_MIN_CLUSTER_LOG_SIZE);
+	} else if (cluster_size) {
+		com_err(program_name, 0,
+			_("specifying a cluster size requires the "
+			  "bigalloc feature"));
+		exit(1);
 	} else
 		fs_param.s_log_cluster_size = fs_param.s_log_block_size;