From: Pieter Lexis <pieter.lexis@powerdns.com>
Date: Tue, 7 Oct 2025 10:34:06 +0000 (+0200)
Subject: fix(dnsdist): fix crash on empty selected backend
X-Git-Tag: rec-5.4.0-alpha1~187^2~9
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9cff20348285472aa77ed16999b5f922bd0d5d21;p=thirdparty%2Fpdns.git

fix(dnsdist): fix crash on empty selected backend
---

diff --git a/pdns/dnsdistdist/dnsdist.cc b/pdns/dnsdistdist/dnsdist.cc
index 718e584904..c424d7e0a8 100644
--- a/pdns/dnsdistdist/dnsdist.cc
+++ b/pdns/dnsdistdist/dnsdist.cc
@@ -1465,7 +1465,7 @@ static ServerPolicy::SelectedBackend selectBackendForOutgoingQuery(DNSQuestion&
   const auto& servers = serverPool.getServers();
   auto selectedBackend = policy.getSelectedBackend(servers, dnsQuestion);
 
-  if (auto tracer = dnsQuestion.ids.getTracer(); tracer != nullptr && dnsQuestion.ids.tracingEnabled) {
+  if (auto tracer = dnsQuestion.ids.getTracer(); tracer != nullptr && selectedBackend && dnsQuestion.ids.tracingEnabled) {
     tracer->setSpanAttribute(closer.getSpanID(), "backend.name", AnyValue{selectedBackend->getNameWithAddr()});
     tracer->setSpanAttribute(closer.getSpanID(), "backend.id", AnyValue{boost::uuids::to_string(selectedBackend->getID())});
   }