From: Vladimír Čunát <vladimir.cunat@nic.cz>
Date: Fri, 14 Sep 2018 08:21:43 +0000 (+0200)
Subject: misc nitpicks
X-Git-Tag: v3.1.0~15^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9d05c1f00ec49113cbfda5bc782c564679ab89af;p=thirdparty%2Fknot-resolver.git

misc nitpicks

- \param family, esp. don't rely on AF_UNSPEC being zero
- kres_gnutls_vec_push(): don't uv_write() if ENOMEM
- tls_client_params_clear(): remove unused function
---

diff --git a/daemon/io.c b/daemon/io.c
index c82462f7f..e5b8a139a 100644
--- a/daemon/io.c
+++ b/daemon/io.c
@@ -271,7 +271,7 @@ static void _tcp_accept(uv_stream_t *master, int status, bool tls)
 		return;
 	}
 	memset(client, 0, sizeof(*client));
-	int res = io_create(master->loop, (uv_handle_t *)client, SOCK_STREAM, 0);
+	int res = io_create(master->loop, (uv_handle_t *)client, SOCK_STREAM, AF_UNSPEC);
 	if (res) {
 		if (res == UV_EMFILE) {
 			worker->too_many_open = true;
diff --git a/daemon/io.h b/daemon/io.h
index 51976b07e..428cc62a3 100644
--- a/daemon/io.h
+++ b/daemon/io.h
@@ -59,7 +59,9 @@ int tcp_bind_tls(uv_tcp_t *handle, struct sockaddr *addr);
 int tcp_bindfd(uv_tcp_t *handle, int fd);
 int tcp_bindfd_tls(uv_tcp_t *handle, int fd);
 
-/** Initialize the handle, incl. ->data = struct session * instance. type = SOCK_* */
+/** Initialize the handle, incl. ->data = struct session * instance.
+ * \param type = SOCK_*
+ * \param family = AF_* */
 int io_create(uv_loop_t *loop, uv_handle_t *handle, int type, unsigned family);
 void io_deinit(uv_handle_t *handle);
 void io_free(uv_handle_t *handle);
diff --git a/daemon/tls.c b/daemon/tls.c
index 0b31dca25..0fdc6f9e1 100644
--- a/daemon/tls.c
+++ b/daemon/tls.c
@@ -203,7 +203,7 @@ static ssize_t kres_gnutls_vec_push(gnutls_transport_ptr_t h, const giovec_t * i
 		} else {
 			free(buf);
 			errno = ENOMEM;
-			ret = -1;
+			return -1;
 		}
 
 		/* Perform an asynchronous write with a callback */
@@ -781,29 +781,6 @@ static int client_paramlist_entry_clear(const char *k, void *v, void *baton)
 	return client_paramlist_entry_free(entry);
 }
 
-int tls_client_params_clear(map_t *tls_client_paramlist, const char *addr, uint16_t port)
-{
-	if (!tls_client_paramlist || !addr) {
-		return kr_error(EINVAL);
-	}
-
-	/* Parameters are OK */
-
-	char key[INET6_ADDRSTRLEN + 6];
-	size_t keylen = sizeof(key);
-	if (kr_straddr_join(addr, port, key, &keylen) != kr_ok()) {
-		return kr_error(EINVAL);
-	}
-
-	struct tls_client_paramlist_entry *entry = map_get(tls_client_paramlist, key);
-	if (entry != NULL) {
-		client_paramlist_entry_unref(entry);
-		map_del(tls_client_paramlist, key);
-	}
-
-	return kr_ok();
-}
-
 int tls_client_params_set(map_t *tls_client_paramlist,
 			  const char *addr, uint16_t port,
 			  const char *param, tls_client_param_t param_type)
diff --git a/daemon/tls.h b/daemon/tls.h
index ce13d20bb..d208f4cb8 100644
--- a/daemon/tls.h
+++ b/daemon/tls.h
@@ -167,9 +167,6 @@ int tls_set_hs_state(struct tls_common_ctx *ctx, tls_hs_state_t state);
 struct tls_client_paramlist_entry *tls_client_try_upgrade(map_t *tls_client_paramlist,
 			  const struct sockaddr *addr);
 
-/*! Clear (remove) TLS parameters for given address. */
-int tls_client_params_clear(map_t *tls_client_paramlist, const char *addr, uint16_t port);
-
 /*! Set TLS authentication parameters for given address.
  * Note: hostnames must be imported before ca files,
  *       otherwise ca files will not be imported at all.