From: Victor Julien <victor@inliniac.net>
Date: Wed, 11 Dec 2013 09:31:27 +0000 (+0100)
Subject: dns: suppress minor scan-build warnings
X-Git-Tag: suricata-2.0beta2~15
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9d092f35e2fe1206e027edb3211228a39960d04d;p=thirdparty%2Fsuricata.git

dns: suppress minor scan-build warnings

These were only used if debug is enabled.

app-layer-dns-tcp.c:407:13: warning: Value stored to 'length' is never read
            length = *data;
app-layer-dns-udp.c:236:13: warning: Value stored to 'length' is never read
            length = *data;
---

diff --git a/src/app-layer-dns-tcp.c b/src/app-layer-dns-tcp.c
index 6fbb4fc8cc..0e7626a65a 100644
--- a/src/app-layer-dns-tcp.c
+++ b/src/app-layer-dns-tcp.c
@@ -404,8 +404,7 @@ static int DNSReponseParseData(Flow *f, DNSState *dns_state, const uint8_t *inpu
                 goto insufficient_data;
             }
 
-            length = *data;
-            SCLogDebug("length %u", length);
+            SCLogDebug("length %u", *data);
         }
         if (fqdn_offset) {
             fqdn_offset--;
diff --git a/src/app-layer-dns-udp.c b/src/app-layer-dns-udp.c
index 4acd168f98..6202bda46b 100644
--- a/src/app-layer-dns-udp.c
+++ b/src/app-layer-dns-udp.c
@@ -233,8 +233,7 @@ static int DNSUDPResponseParse(Flow *f, void *dstate,
                 goto insufficient_data;
             }
 
-            length = *data;
-            SCLogDebug("length %u", length);
+            SCLogDebug("length %u", *data);
         }
         if (fqdn_offset) {
             fqdn_offset--;