From: Uwe Kleine-König Date: Tue, 2 Dec 2025 15:13:53 +0000 (+0100) Subject: PCI/portdrv: Don't check for valid device and driver in bus callbacks X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9d29a9c06f3e88e47ae43a26b61eebe7372dbee3;p=thirdparty%2Fkernel%2Flinux.git PCI/portdrv: Don't check for valid device and driver in bus callbacks The driver core ensures that in .probe() and .remove() both dev and dev->driver are valid. So drop the respective check. Signed-off-by: Uwe Kleine-König Signed-off-by: Bjorn Helgaas Reviewed-by: Jonathan Cameron Link: https://patch.msgid.link/2cc2e15e05318b9f0d7b6a2b69b3169d2a6f0bd3.1764688034.git.u.kleine-koenig@baylibre.com --- diff --git a/drivers/pci/pcie/portdrv.c b/drivers/pci/pcie/portdrv.c index 0127e3dc768f..7bd48c5da133 100644 --- a/drivers/pci/pcie/portdrv.c +++ b/drivers/pci/pcie/portdrv.c @@ -537,9 +537,6 @@ static int pcie_port_probe_service(struct device *dev) struct pcie_port_service_driver *driver; int status; - if (!dev || !dev->driver) - return -ENODEV; - driver = to_service_driver(dev->driver); if (!driver || !driver->probe) return -ENODEV; @@ -567,9 +564,6 @@ static int pcie_port_remove_service(struct device *dev) struct pcie_device *pciedev; struct pcie_port_service_driver *driver; - if (!dev || !dev->driver) - return 0; - pciedev = to_pcie_device(dev); driver = to_service_driver(dev->driver); if (driver && driver->remove)