From: Alan T. DeKok <aland@freeradius.org>
Date: Mon, 11 Dec 2017 21:49:14 +0000 (-0500)
Subject: opc may be NULL
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9d29cdf6c719eca8ad7c2fa7ce0bbef09455ac19;p=thirdparty%2Ffreeradius-server.git

opc may be NULL
---

diff --git a/src/modules/rlm_eap/lib/sim/vector.c b/src/modules/rlm_eap/lib/sim/vector.c
index 92a4a3691db..f73e709bba9 100644
--- a/src/modules/rlm_eap/lib/sim/vector.c
+++ b/src/modules/rlm_eap/lib/sim/vector.c
@@ -37,7 +37,7 @@ RCSID("$Id$")
 static int vector_gsm_from_ki(eap_session_t *eap_session, VALUE_PAIR *vps, int idx, fr_sim_keys_t *keys)
 {
 	REQUEST		*request = eap_session->request;
-	VALUE_PAIR	*ki, *opc, *version_vp;
+	VALUE_PAIR	*ki, *version_vp, *opc = NULL;
 	uint32_t	version;
 	int		i;
 
@@ -102,6 +102,11 @@ static int vector_gsm_from_ki(eap_session_t *eap_session, VALUE_PAIR *vps, int i
 		break;
 
 	case 4:
+		if (!opc) {
+			RPEDEBUG2("No SIM-OPc");
+			return -1;
+		}
+
 		if (milenage_gsm_generate(keys->gsm.vector[idx].sres,
 					  keys->gsm.vector[idx].kc,
 					  opc->vp_octets,