From: John Ferlan <jferlan@redhat.com>
Date: Wed, 27 Aug 2014 13:14:16 +0000 (-0400)
Subject: qemu_driver: Resolve Coverity CONSTANT_EXPRESSION_RESULT
X-Git-Tag: v1.2.8-rc2~35
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9d7254de430f7ef7a4c6a2a20718942369ce9d06;p=thirdparty%2Flibvirt.git

qemu_driver: Resolve Coverity CONSTANT_EXPRESSION_RESULT

The call to virDomainSnapshotRedefinePrep() had a spurrious ! in front of
it which caused Coverity to complan that the expression is always false.
---

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 2db507f829..73959dab4a 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -13461,8 +13461,8 @@ qemuDomainSnapshotCreateXML(virDomainPtr domain,
     }
 
     if (redefine) {
-        if (!virDomainSnapshotRedefinePrep(domain, vm, &def, &snap,
-                                           &update_current, flags) < 0)
+        if (virDomainSnapshotRedefinePrep(domain, vm, &def, &snap,
+                                          &update_current, flags) < 0)
             goto cleanup;
     } else {
         /* Easiest way to clone inactive portion of vm->def is via