From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Fri, 8 Feb 2013 01:29:47 +0000 (-0500)
Subject: - encourage requirements to be in the dialect module,
X-Git-Tag: rel_0_8_0~23^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9e3cd16c2174f5e6e4364803e940bdb4b8c1e6fa;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

- encourage requirements to be in the dialect module,
document running SQLA main tests with external dialect
---

diff --git a/README.dialects.rst b/README.dialects.rst
index ccc9231958..2e1d20db82 100644
--- a/README.dialects.rst
+++ b/README.dialects.rst
@@ -37,9 +37,9 @@ The file structure of a dialect is typically similar to the following::
                                               __init__.py
                                               base.py
                                               <dbapi>.py
+                                              requirements.py
                          test/
                                               __init__.py
-                                              requirements.py
                                               test_suite.py
                                               test_<dialect_specific_test>.py
                                               ...
@@ -76,12 +76,12 @@ Key aspects of this file layout include:
     [nosetests]
     with-sqla_testing = true
     where = test
-    cover-package = sqlalchemy-access
+    cover-package = sqlalchemy_access
     with-coverage = 1
     cover-erase = 1
 
     [sqla_testing]
-    requirement_cls=test.requirements:Requirements
+    requirement_cls=sqlalchemy_access.requirements:Requirements
     profile_file=.profiles.txt
 
     [db]
@@ -125,7 +125,7 @@ Key aspects of this file layout include:
     $ python run_tests.py -v
 
 * requirements.py - The ``requirements.py`` file is where directives
-  regarding database and dialect   capabilities are set up.
+  regarding database and dialect capabilities are set up.
   SQLAlchemy's tests are often annotated with decorators   that mark
   tests as "skip" or "fail" for particular backends.  Over time, this
   system   has been refined such that specific database and DBAPI names
@@ -142,7 +142,7 @@ Key aspects of this file layout include:
   the RETURNING construct but does not support reflection of tables
   might look like this::
 
-      # test/requirements.py
+      # sqlalchemy_access/requirements.py
 
       from sqlalchemy.testing.requirements import SuiteRequirements
 
@@ -162,6 +162,17 @@ Key aspects of this file layout include:
   requirements rules, which attempt to have reasonable defaults. The
   tests will report on those requirements found as they are run.
 
+  The requirements system can also be used when running SQLAlchemy's
+  primary test suite against the external dialect.  In this use case,
+  a ``--dburi`` as well as a ``--requirements`` flag are passed to SQLAlchemy's
+  main test runner ``./sqla_nose.py`` so that exclusions specific to the
+  dialect take place::
+
+    cd /path/to/sqlalchemy
+    python ./sqla_nose.py -v \
+      --requirements sqlalchemy_access.requirements:Requirements \
+      --dburi access+pyodbc://admin@access_test
+
 * test_suite.py - Finally, the ``test_suite.py`` module represents a
   Nose test suite, which pulls   in the actual SQLAlchemy test suite.
   To pull in the suite as a whole, it can   be imported in one step::