From: Simon Green Date: Wed, 29 Jul 2015 09:38:37 +0000 (-0400) Subject: Bug 399078 - Remove the 'musthavemilestoneonaccept' parameter X-Git-Tag: release-5.1.1~215 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9e518c6b33f5b6aadb363ff0786a391c1fda6d7b;p=thirdparty%2Fbugzilla.git Bug 399078 - Remove the 'musthavemilestoneonaccept' parameter r=gerv, a=simon --- diff --git a/Bugzilla/API/1_0/Resource/Bugzilla.pm b/Bugzilla/API/1_0/Resource/Bugzilla.pm index de9925e695..d7c3ab4010 100644 --- a/Bugzilla/API/1_0/Resource/Bugzilla.pm +++ b/Bugzilla/API/1_0/Resource/Bugzilla.pm @@ -62,7 +62,6 @@ use constant PARAMETERS_LOGGED_IN => qw( attachment_base commentonchange_resolution commentonduplicate - cookiepath defaultopsys defaultplatform defaultpriority @@ -443,7 +442,6 @@ A logged-in user can access the following parameters (listed alphabetically): C, C, C, - C, C, C, C, diff --git a/Bugzilla/CGI.pm b/Bugzilla/CGI.pm index 0b1712d2ff..fcca0ec6a8 100644 --- a/Bugzilla/CGI.pm +++ b/Bugzilla/CGI.pm @@ -430,7 +430,8 @@ sub send_cookie { ThrowCodeError('cookies_need_value') unless $paramhash{'-value'}; # Add the default path and the domain in. - $paramhash{'-path'} = Bugzilla->params->{'cookiepath'}; + my $uri = URI->new(Bugzilla->params->{urlbase}); + $paramhash{'-path'} = $uri->path; $paramhash{'-domain'} = Bugzilla->params->{'cookiedomain'} if Bugzilla->params->{'cookiedomain'}; diff --git a/Bugzilla/Config/Core.pm b/Bugzilla/Config/Core.pm index 654e569ba1..de375e4486 100644 --- a/Bugzilla/Config/Core.pm +++ b/Bugzilla/Config/Core.pm @@ -35,12 +35,6 @@ use constant get_param_list => ( default => '', checker => \&check_sslbase }, - - { - name => 'cookiepath', - type => 't', - default => '/' - }, ); 1; diff --git a/Bugzilla/WebService/Bugzilla.pm b/Bugzilla/WebService/Bugzilla.pm index a9cef32fc8..c0b44a04ca 100644 --- a/Bugzilla/WebService/Bugzilla.pm +++ b/Bugzilla/WebService/Bugzilla.pm @@ -56,7 +56,6 @@ use constant PARAMETERS_LOGGED_IN => qw( attachment_base commentonchange_resolution commentonduplicate - cookiepath defaultopsys defaultplatform defaultpriority @@ -412,7 +411,6 @@ A logged-in user can access the following parameters (listed alphabetically): C, C, C, - C, C, C, C, diff --git a/docs/en/rst/administering/parameters.rst b/docs/en/rst/administering/parameters.rst index f040bcfc67..974e7a16df 100644 --- a/docs/en/rst/administering/parameters.rst +++ b/docs/en/rst/administering/parameters.rst @@ -40,15 +40,6 @@ sslbase the :param:`sslbase` should be set to :paramval:`https://www.foo.com/bugzilla/`. -cookiepath - Defines a path, relative to the web document root, that Bugzilla - cookies will be restricted to. For example, if the - :param:`urlbase` is set to - :file:`http://www.foo.com/bugzilla/`, the - :param:`cookiepath` should be set to - :paramval:`/bugzilla/`. Setting it to :paramval:`/` will allow all sites - served by this web server or virtual host to read Bugzilla cookies. - .. _param-general: General diff --git a/docs/en/rst/api/core/v1/bugzilla.rst b/docs/en/rst/api/core/v1/bugzilla.rst index c2458bd0f5..5aca556ecb 100644 --- a/docs/en/rst/api/core/v1/bugzilla.rst +++ b/docs/en/rst/api/core/v1/bugzilla.rst @@ -171,7 +171,6 @@ Example response for authenticated user: "attachment_base" : "http://bugzilla.example.com/", "commentonchange_resolution" : "0", "commentonduplicate" : "0", - "cookiepath" : "/", "createemailregexp" : ".*", "defaultopsys" : "", "defaultplatform" : "", @@ -209,7 +208,6 @@ A logged-in user can access the following parameters (listed alphabetically): * attachment_base * commentonchange_resolution * commentonduplicate -* cookiepath * defaultopsys * defaultplatform * defaultpriority diff --git a/template/en/default/admin/params/core.html.tmpl b/template/en/default/admin/params/core.html.tmpl index d7703b5b84..decd8895a7 100644 --- a/template/en/default/admin/params/core.html.tmpl +++ b/template/en/default/admin/params/core.html.tmpl @@ -24,12 +24,4 @@ _ " using the sslbase parameter. Also, when this is enabled," _ " Bugzilla will send out links using sslbase in emails" _ " instead of urlbase.", - - cookiepath => "Path, relative to your web document root, to which to restrict " _ - "Bugzilla cookies. Normally this is the URI portion of your URL " _ - "base. Begin with a / (single slash mark). For instance, if " _ - "Bugzilla serves from 'http://www.somedomain.com/bugzilla/', set " _ - "this parameter to /bugzilla/. Setting it to / will allow " _ - "all sites served by this web server or virtual host to read " _ - "Bugzilla cookies.", } %] diff --git a/template/en/default/global/header.html.tmpl b/template/en/default/global/header.html.tmpl index b05784ebe3..98cd42980c 100644 --- a/template/en/default/global/header.html.tmpl +++ b/template/en/default/global/header.html.tmpl @@ -183,7 +183,6 @@ #%] var BUGZILLA = { param: { - cookiepath: '[% Param('cookiepath') FILTER js %]', maxusermatches: [% Param('maxusermatches') FILTER js %] }, constant: { diff --git a/template/en/default/welcome-admin.html.tmpl b/template/en/default/welcome-admin.html.tmpl index a9b30f68a7..5b586a0157 100644 --- a/template/en/default/welcome-admin.html.tmpl +++ b/template/en/default/welcome-admin.html.tmpl @@ -36,9 +36,6 @@ reason you see this page: as long as this parameter is not set, you will see this page again and again). -
  • cookiepath is important - for your browser to manage your cookies correctly.
    • -
  • maintainer, the person responsible for this installation if something is running wrongly.