From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Tue, 7 Mar 2017 20:00:18 +0000 (-0500)
Subject: Repair missing "checkfirst" for test suite
X-Git-Tag: rel_1_1_7~14
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9e627159733da48e2fd2d25de93589eb079a75f4;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

Repair missing "checkfirst" for test suite

the test_metadata tests trigger the before_create dispatch without
the checkfirst flag.  Postgresql backend should be able to
tolerate this.

Change-Id: Ife497cc3a4eb2812462116f94aad732864225f3f
---

diff --git a/lib/sqlalchemy/dialects/postgresql/base.py b/lib/sqlalchemy/dialects/postgresql/base.py
index aaaa64cf16..db52642f83 100644
--- a/lib/sqlalchemy/dialects/postgresql/base.py
+++ b/lib/sqlalchemy/dialects/postgresql/base.py
@@ -1245,24 +1245,24 @@ class ENUM(sqltypes.Enum):
         else:
             return False
 
-    def _on_table_create(self, target, bind, checkfirst, **kw):
+    def _on_table_create(self, target, bind, checkfirst=False, **kw):
         if checkfirst or (
                 not self.metadata and
                 not kw.get('_is_metadata_operation', False)) and \
                 not self._check_for_name_in_memos(checkfirst, kw):
             self.create(bind=bind, checkfirst=checkfirst)
 
-    def _on_table_drop(self, target, bind, checkfirst, **kw):
+    def _on_table_drop(self, target, bind, checkfirst=False, **kw):
         if not self.metadata and \
             not kw.get('_is_metadata_operation', False) and \
                 not self._check_for_name_in_memos(checkfirst, kw):
             self.drop(bind=bind, checkfirst=checkfirst)
 
-    def _on_metadata_create(self, target, bind, checkfirst, **kw):
+    def _on_metadata_create(self, target, bind, checkfirst=False, **kw):
         if not self._check_for_name_in_memos(checkfirst, kw):
             self.create(bind=bind, checkfirst=checkfirst)
 
-    def _on_metadata_drop(self, target, bind, checkfirst, **kw):
+    def _on_metadata_drop(self, target, bind, checkfirst=False, **kw):
         if not self._check_for_name_in_memos(checkfirst, kw):
             self.drop(bind=bind, checkfirst=checkfirst)
 
diff --git a/test/sql/test_metadata.py b/test/sql/test_metadata.py
index 56ef8e6289..bd67b6f69b 100644
--- a/test/sql/test_metadata.py
+++ b/test/sql/test_metadata.py
@@ -1532,6 +1532,7 @@ class PKAutoIncrementTest(fixtures.TestBase):
 
 
 class SchemaTypeTest(fixtures.TestBase):
+    __backend__ = True
 
     class TrackEvents(object):
         column = None