From: Peter Krempa <pkrempa@redhat.com>
Date: Thu, 21 Jul 2022 12:39:01 +0000 (+0200)
Subject: qemuDomainRemoveDiskDevice: Remove special casing for disks on 'sd' bus
X-Git-Tag: v8.7.0-rc1~81
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9e6cca0560e7239b07e8eeaaf72038fd48b266ee;p=thirdparty%2Flibvirt.git

qemuDomainRemoveDiskDevice: Remove special casing for disks on 'sd' bus

SD card disks can't be detached, so it makes no sense to special case
them in the unplug code.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index e2d30d5873..ec73961895 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -4282,7 +4282,7 @@ qemuDomainRemoveDiskDevice(virQEMUDriver *driver,
 
         if (!(diskBackend = qemuBlockStorageSourceChainDetachPrepareChardev(chardevAlias)))
             goto cleanup;
-    } else if (blockdev && !qemuDiskBusIsSD(disk->bus)) {
+    } else if (blockdev) {
         if (diskPriv->blockjob) {
             /* the block job keeps reference to the disk chain */
             diskPriv->blockjob->disk = NULL;