From: Sumeet Pawnikar Date: Sat, 31 Jan 2026 15:16:15 +0000 (+0530) Subject: drivers: thermal: intel: tcc_cooling: Drop redundant local variable X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9eb9c350bc553fae5d77d698192198087ca47c64;p=thirdparty%2Flinux.git drivers: thermal: intel: tcc_cooling: Drop redundant local variable Simplify the error path by directly returning PTR_ERR(tcc_cdev) instead of storing it in an intermediate variable ret which can be dropped then because it is only used for that. Also remove an uneeded empty line before the declaration of local variable err. Signed-off-by: Sumeet Pawnikar [ rjw: Dropped unneeded changes, rewrote changelog, adjusted subject ] Link: https://patch.msgid.link/20260131151615.6230-1-sumeet4linux@gmail.com Signed-off-by: Rafael J. Wysocki --- diff --git a/drivers/thermal/intel/intel_tcc_cooling.c b/drivers/thermal/intel/intel_tcc_cooling.c index 92de161e359a0..6c2ba0ba31788 100644 --- a/drivers/thermal/intel/intel_tcc_cooling.c +++ b/drivers/thermal/intel/intel_tcc_cooling.c @@ -76,10 +76,8 @@ MODULE_DEVICE_TABLE(x86cpu, tcc_ids); static int __init tcc_cooling_init(void) { - int ret; u64 val; const struct x86_cpu_id *id; - int err; id = x86_match_cpu(tcc_ids); @@ -107,10 +105,9 @@ static int __init tcc_cooling_init(void) tcc_cdev = thermal_cooling_device_register("TCC Offset", NULL, &tcc_cooling_ops); - if (IS_ERR(tcc_cdev)) { - ret = PTR_ERR(tcc_cdev); - return ret; - } + if (IS_ERR(tcc_cdev)) + return PTR_ERR(tcc_cdev); + return 0; }