From: Mike Bayer Date: Thu, 13 Feb 2020 20:43:05 +0000 (-0500) Subject: Fractional seconds starts at Python 3.7 X-Git-Tag: rel_1_3_14~21 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9ec151bbe4c31d8abe6de4cd36bd549c28dea536;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git Fractional seconds starts at Python 3.7 CI didn't notice that the fractional seconds in the new SQL Server DATETIMEOFFSET test are not available on Python 3.6. It was inadvertently assumed this was a Python 2 incompatibility. Change-Id: I9839eafbf7c37512eef1ecf666846983f9651c02 (cherry picked from commit 55f6d61e85b7f16df0b77f1c55a4fb051cd696e3) --- diff --git a/lib/sqlalchemy/testing/requirements.py b/lib/sqlalchemy/testing/requirements.py index 301839eb38..01f32d495a 100644 --- a/lib/sqlalchemy/testing/requirements.py +++ b/lib/sqlalchemy/testing/requirements.py @@ -960,6 +960,13 @@ class SuiteRequirements(Requirements): lambda: sys.version_info < (3,), "Python version 3.xx is required." ) + @property + def python37(self): + return exclusions.skip_if( + lambda: sys.version_info < (3, 7), + "Python version 3.7 or greater is required.", + ) + @property def cpython(self): return exclusions.only_if( diff --git a/test/dialect/mssql/test_types.py b/test/dialect/mssql/test_types.py index d7fbccac26..1f0ae0a6fa 100644 --- a/test/dialect/mssql/test_types.py +++ b/test/dialect/mssql/test_types.py @@ -794,7 +794,7 @@ class TypeRoundTripTest( ), None, True, - testing.requires.python3, + testing.requires.python37, ), ( "dto_param_datetime_naive",