From: Michael Tremer <michael.tremer@ipfire.org>
Date: Sat, 31 Jul 2010 18:52:29 +0000 (+0200)
Subject: network: Fix duplicate check.
X-Git-Tag: 001~27
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9eebfc55a2e00a4fddafe90768f86a165a7036c4;p=network.git

network: Fix duplicate check.
---

diff --git a/functions.ipv4 b/functions.ipv4
index 04b49a68..74c524a4 100644
--- a/functions.ipv4
+++ b/functions.ipv4
@@ -61,10 +61,10 @@ function ipv4_detect_duplicate() {
 
 	if ! arping -q -c 2 -w 3 -D -I ${device} ${address}; then
 		log DEBUG "Detected duplicate address '${address}' on device '${device}'."
-		return ${EXIT_ERROR}
+		return ${EXIT_OK}
 	fi
 
-	return ${EXIT_OK}
+	return ${EXIT_ERROR}
 }
 
 function ipv4_update_neighbours() {
diff --git a/hooks/zones/bridge.configs/ipv4-static b/hooks/zones/bridge.configs/ipv4-static
index 5793321c..c9462d5e 100755
--- a/hooks/zones/bridge.configs/ipv4-static
+++ b/hooks/zones/bridge.configs/ipv4-static
@@ -79,7 +79,7 @@ function _up() {
 
 	if ! zone_has_ipv4 ${zone} ${ADDRESS}/${PREFIX}; then
 		if ipv4_detect_duplicate ${zone} ${ADDRESS}; then
-			error_log "Duplicate address detected on zone '${zone}' (${address})."
+			error_log "Duplicate address detected on zone '${zone}' (${ADDRESS})."
 			error_log "Cannot continue."
 			exit ${EXIT_ERROR}
 		fi