From: Julian Seward <jseward@acm.org>
Date: Wed, 21 Jul 2010 16:00:08 +0000 (+0000)
Subject: Put quotes around the argument to /usr/bin/dsymutil, so it doesn't
X-Git-Tag: svn/VALGRIND_3_6_0~226
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9eeffc3968e38f3e902db4d3f0c08c8900fa9eb0;p=thirdparty%2Fvalgrind.git

Put quotes around the argument to /usr/bin/dsymutil, so it doesn't
screw up on filenames with spaces.  Fixes (part of) #205093.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11219
---

diff --git a/coregrind/m_debuginfo/readmacho.c b/coregrind/m_debuginfo/readmacho.c
index b6b746e418..68ba359f21 100644
--- a/coregrind/m_debuginfo/readmacho.c
+++ b/coregrind/m_debuginfo/readmacho.c
@@ -948,10 +948,12 @@ Bool ML_(read_macho_debug_info)( struct _DebugInfo* di )
      HChar* cmd = ML_(dinfo_zalloc)( "di.readmacho.tmp1", 
                                      VG_(strlen)(dsymutil)
                                      + VG_(strlen)(di->filename)
-                                     + 30 /* misc */ );
+                                     + 32 /* misc */ );
      VG_(strcpy)(cmd, dsymutil);
      if (0) VG_(strcat)(cmd, "--verbose ");
+     VG_(strcat)(cmd, "\"");
      VG_(strcat)(cmd, di->filename);
+     VG_(strcat)(cmd, "\"");
      VG_(message)(Vg_DebugMsg, "run: %s\n", cmd);
      r = VG_(system)( cmd );
      if (r)