From: gerv%gerv.net <>
Date: Tue, 6 Apr 2004 04:53:10 +0000 (+0000)
Subject: Bug 230293 - Send CSV buglists with "Content-Disposition: attachment". Patch by gerv... 
X-Git-Tag: bugzilla-2.18rc1~112
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9efdf77d17bb89a4e9a82081b5412f42e63879ee;p=thirdparty%2Fbugzilla.git

Bug 230293 - Send CSV buglists with "Content-Disposition: attachment". Patch by gerv; r,a=justdave.
---

diff --git a/buglist.cgi b/buglist.cgi
index 64d7beed04..032ce02bc5 100755
--- a/buglist.cgi
+++ b/buglist.cgi
@@ -866,6 +866,7 @@ if ($dotweak) {
 # Generate HTTP headers
 
 my $contenttype;
+my $disp = "inline";
 
 if ($format->{'extension'} eq "html") {
     my $cookiepath = Param("cookiepath");
@@ -894,6 +895,12 @@ else {
     $contenttype = $format->{'ctype'};
 }
 
+if ($format->{'extension'} eq "csv") {
+    # We set CSV files to be downloaded, as they are designed for importing
+    # into other programs.
+    $disp = "attachment";
+}
+
 if ($serverpush) {
     print $cgi->multipart_start(-type=>$contenttype);
 } else {
@@ -901,7 +908,7 @@ if ($serverpush) {
     # If we are doing server push, then we did this already in the HTTP headers
     # that started the server push, so we don't have to do it again here.
     print $cgi->header(-type => $contenttype,
-                       -content_disposition => "inline; filename=$filename");
+                       -content_disposition => "$disp; filename=$filename");
 }