From: Thomas Jarosch <thomas.jarosch@intra2net.com>
Date: Mon, 3 Oct 2011 05:23:18 +0000 (+0000)
Subject: Fix wrong sanity check in choke_parse_opt()
X-Git-Tag: v3.0.0~9
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9f1ba57016da5e65b83092f5ab05565091e0879d;p=thirdparty%2Fiproute2.git

Fix wrong sanity check in choke_parse_opt()

Detected by cppcheck.

Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
---

diff --git a/tc/q_choke.c b/tc/q_choke.c
index 6e54cb71a..04a864f3b 100644
--- a/tc/q_choke.c
+++ b/tc/q_choke.c
@@ -122,7 +122,7 @@ static int choke_parse_opt(struct qdisc_util *qu, int argc, char **argv,
 		return -1;
 	}
 
-	if (opt.qth_min > opt.qth_min) {
+	if (opt.qth_min >= opt.qth_max) {
 		fprintf(stderr, "\"min\" is not smaller than \"max\"\n");
 		return -1;
 	}