From: Volker Lendecke <vl@samba.org>
Date: Mon, 29 Sep 2025 17:25:41 +0000 (+0200)
Subject: lib: Avoid a talloc_zero in afpinfo_new()
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9f1dd0bbfa685e7c8376fba9ecab6cf0880efd4b;p=thirdparty%2Fsamba.git

lib: Avoid a talloc_zero in afpinfo_new()

Use a struct assignment.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/lib/adouble.c b/source3/lib/adouble.c
index 338b060746d..5836b5df26e 100644
--- a/source3/lib/adouble.c
+++ b/source3/lib/adouble.c
@@ -2806,13 +2806,15 @@ struct smb_filename *adouble_name(TALLOC_CTX *mem_ctx,
  **/
 AfpInfo *afpinfo_new(TALLOC_CTX *ctx)
 {
-	AfpInfo *ai = talloc_zero(ctx, AfpInfo);
+	AfpInfo *ai = talloc(ctx, AfpInfo);
 	if (ai == NULL) {
 		return NULL;
 	}
-	ai->afpi_Signature = AFP_Signature;
-	ai->afpi_Version = AFP_Version;
-	ai->afpi_BackupTime = AD_DATE_START;
+	*ai = (AfpInfo){
+		.afpi_Signature = AFP_Signature,
+		.afpi_Version = AFP_Version,
+		.afpi_BackupTime = AD_DATE_START,
+	};
 	return ai;
 }