From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Sat, 9 Apr 2022 17:44:46 +0000 (-0500)
Subject: Avoid infinite loop in module_root(), oops...
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9f1ee740998d9d6f49d359889e2960e9fbd685b8;p=thirdparty%2Ffreeradius-server.git

Avoid infinite loop in module_root(), oops...
---

diff --git a/src/lib/server/module.c b/src/lib/server/module.c
index fe9c8a5a73..969e6155c7 100644
--- a/src/lib/server/module.c
+++ b/src/lib/server/module.c
@@ -419,17 +419,16 @@ module_instance_t *module_parent(module_instance_t const *child)
  */
 module_instance_t *module_root(module_instance_t const *child)
 {
-	module_instance_t *parent = NULL;
 	module_instance_t *next;
 
 	for (;;) {
 		next = module_parent(child);
 		if (!next) break;
 
-		parent = next;
+		child = next;
 	}
 
-	return parent;
+	return UNCONST(module_instance_t *, child);
 }
 
 /** Find an existing module instance by its private instance data