From: Erik Skultety <eskultet@redhat.com>
Date: Fri, 8 Jun 2018 11:47:31 +0000 (+0200)
Subject: qemu: command: Add virReportEnumRangeError to BuildHostdevCommandline
X-Git-Tag: v4.6.0-rc1~291
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9f26814afdd0b8cec62e4ad248fe95c5d147955e;p=thirdparty%2Flibvirt.git

qemu: command: Add virReportEnumRangeError to BuildHostdevCommandline

Adding the 'default' case to our enum-typecasted switches is the current
safety trend, so add it here for mdevs too.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>
---

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 014d64febe..8a1bfbd5fe 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -5413,10 +5413,10 @@ qemuBuildHostdevCommandLine(virCommandPtr cmd,
                 }
                 break;
             case VIR_MDEV_MODEL_TYPE_LAST:
-                virReportError(VIR_ERR_INTERNAL_ERROR,
-                               _("unexpected vfio type '%d'"), subsys->u.mdev.model);
+            default:
+                virReportEnumRangeError(virMediatedDeviceModelType,
+                                        subsys->u.mdev.model);
                 return -1;
-                break;
             }
 
             virCommandAddArg(cmd, "-device");