From: Yi Wang <wang.yi59@zte.com.cn>
Date: Fri, 26 May 2017 02:12:45 +0000 (-0400)
Subject: util: fix memory leak in virSocketAddrFormatFull
X-Git-Tag: v3.4.0-rc1~13
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9f4c39f3099f7ecbccbc0be521d25ec6185cf2e3;p=thirdparty%2Flibvirt.git

util: fix memory leak in virSocketAddrFormatFull

The @ipv6_host allocated in virAsprintf may be lost when virAsprintf
addrstr failed.

Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
Signed-off-by: Erik Skultety <eskultet@redhat.com>
---

diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c
index 9dffbc7360..95b5274368 100644
--- a/src/util/virsocketaddr.c
+++ b/src/util/virsocketaddr.c
@@ -417,8 +417,10 @@ virSocketAddrFormatFull(const virSocketAddr *addr,
 
         if (virAsprintf(&addrstr, "%s%s%s",
                         ipv6_host ? ipv6_host : host,
-                        separator ? separator : ":", port) == -1)
+                        separator ? separator : ":", port) == -1) {
+            VIR_FREE(ipv6_host);
             goto error;
+        }
 
         VIR_FREE(ipv6_host);
     } else {