From: Victor Julien <vjulien@oisf.net>
Date: Wed, 23 Nov 2022 13:42:21 +0000 (+0100)
Subject: smtp/files: don't modify prev file on open failure
X-Git-Tag: suricata-7.0.0-rc1~338
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9f4dd4fc56a8885bdff0714352dffa5b897f5979;p=thirdparty%2Fsuricata.git

smtp/files: don't modify prev file on open failure
---

diff --git a/src/app-layer-smtp.c b/src/app-layer-smtp.c
index 45836c5efd..9b4a27a676 100644
--- a/src/app-layer-smtp.c
+++ b/src/app-layer-smtp.c
@@ -529,8 +529,9 @@ int SMTPProcessDataChunk(const uint8_t *chunk, uint32_t len,
                         (uint8_t *)entity->filename, flen, (uint8_t *)chunk, len, flags) != 0) {
                 ret = MIME_DEC_ERR_DATA;
                 SCLogDebug("FileOpenFile() failed");
+            } else {
+                SMTPNewFile(tx, files->tail);
             }
-            SMTPNewFile(tx, files->tail);
 
             /* If close in the same chunk, then pass in empty bytes */
             if (state->body_end) {