From: lpsolit%gmail.com <>
Date: Tue, 19 Dec 2006 16:38:49 +0000 (+0000)
Subject: Bug 364286: Code in Classification->products() is suboptimal - Patch by Frédéric... 
X-Git-Tag: bugzilla-2.23.4~148
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9f5ecaad75e76200f8c304083a3244eecf801dff;p=thirdparty%2Fbugzilla.git

Bug 364286: Code in Classification->products() is suboptimal - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
---

diff --git a/Bugzilla/Classification.pm b/Bugzilla/Classification.pm
index 3d264b704d..37ae3a0cca 100644
--- a/Bugzilla/Classification.pm
+++ b/Bugzilla/Classification.pm
@@ -106,12 +106,8 @@ sub products {
             SELECT id FROM products
             WHERE classification_id = ?
             ORDER BY name}, undef, $self->id);
- 
-        my @products;
-        foreach my $product_id (@$product_ids) {
-            push (@products, new Bugzilla::Product($product_id));
-        }
-        $self->{'products'} = \@products;
+
+        $self->{'products'} = Bugzilla::Product->new_from_list($product_ids);
     }
     return $self->{'products'};
 }