From: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Date: Wed, 9 Mar 2022 10:03:41 +0000 (+0530)
Subject: src/log.c: fix checkpatch.pl warnings
X-Git-Tag: v3.0~185
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9f72cfd0ad444639dab4fa0630a8c365b9337034;p=thirdparty%2Flibcgroup.git

src/log.c: fix checkpatch.pl warnings

Fix all of the warnings/errors reported by Linux Kernel's checkpatch.pl,
except SPDX_LICENSE_TAG, USE_NEGATIVE_ERRNO types.  It also introduces
reverse xmas tree local variable declarations and header file
reordering.

In summary, this patch fixes the following checkpatch.pl
recommendations:
total: 0 errors, 3 warnings, 96 lines checked

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
---

diff --git a/src/log.c b/src/log.c
index f6a386d4..2d524a36 100644
--- a/src/log.c
+++ b/src/log.c
@@ -14,11 +14,12 @@
 
 #include <libcgroup.h>
 #include <libcgroup-internal.h>
+
+#include <strings.h>
 #include <stdarg.h>
-#include <stdio.h>
 #include <stdlib.h>
 #include <errno.h>
-#include <strings.h>
+#include <stdio.h>
 
 static cgroup_logger_callback cgroup_logger;
 static void *cgroup_logger_userdata;
@@ -46,7 +47,7 @@ void cgroup_log(int level, const char *fmt, ...)
 }
 
 void cgroup_set_logger(cgroup_logger_callback logger, int loglevel,
-		void *userdata)
+		       void *userdata)
 {
 	cgroup_logger = logger;
 	cgroup_set_loglevel(loglevel);
@@ -63,6 +64,7 @@ int cgroup_parse_log_level_str(const char *levelstr)
 {
 	char *end;
 	long level;
+
 	errno = 0;
 
 	/* try to parse integer first */
@@ -88,6 +90,7 @@ void cgroup_set_loglevel(int loglevel)
 		cgroup_loglevel = loglevel;
 	else {
 		char *level_str = getenv("CGROUP_LOGLEVEL");
+
 		if (level_str != NULL)
 			cgroup_loglevel = cgroup_parse_log_level_str(level_str);
 		else