From: Alejandro Colomar <alx@kernel.org>
Date: Sat, 7 Dec 2024 14:01:19 +0000 (+0100)
Subject: lib/: sget*ent(): Remove unnecessary 'static', and rename variable
X-Git-Tag: 4.18.0-rc1~58
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9f7464cd6880288cd960e0a83c100c4964967486;p=thirdparty%2Fshadow.git

lib/: sget*ent(): Remove unnecessary 'static', and rename variable

For consistency, use 'fields[]' in all these functions,
and don't make it unnecessarily 'static'.

Signed-off-by: Alejandro Colomar <alx@kernel.org>
---

diff --git a/lib/gshadow.c b/lib/gshadow.c
index efb046299..9e9e25100 100644
--- a/lib/gshadow.c
+++ b/lib/gshadow.c
@@ -73,7 +73,7 @@ sgetsgent(const char *s)
 {
 	static char  *dup = NULL;
 
-	char *fields[FIELDS];
+	char  *fields[FIELDS];
 	char *cp;
 	int i;
 
diff --git a/lib/sgetgrent.c b/lib/sgetgrent.c
index da5601ffc..8d675a3fe 100644
--- a/lib/sgetgrent.c
+++ b/lib/sgetgrent.c
@@ -69,10 +69,11 @@ struct group *
 sgetgrent(const char *s)
 {
 	static char         *dup = NULL;
-	static char *grpfields[NFIELDS];
 	static struct group grent;
+
 	int i;
 	char *cp;
+	char  *fields[NFIELDS];
 
 	free(dup);
 	dup = strdup(s);
@@ -82,21 +83,20 @@ sgetgrent(const char *s)
 	stpsep(dup, "\n");
 
 	for (cp = dup, i = 0; (i < NFIELDS) && (NULL != cp); i++)
-		grpfields[i] = strsep(&cp, ":");
+		fields[i] = strsep(&cp, ":");
 
-	if (i < NFIELDS || streq(grpfields[2], "") || cp != NULL) {
+	if (i < NFIELDS || streq(fields[2], "") || cp != NULL) {
 		return NULL;
 	}
-	grent.gr_name = grpfields[0];
-	grent.gr_passwd = grpfields[1];
-	if (get_gid(grpfields[2], &grent.gr_gid) == -1) {
+	grent.gr_name = fields[0];
+	grent.gr_passwd = fields[1];
+	if (get_gid(fields[2], &grent.gr_gid) == -1) {
 		return NULL;
 	}
-	grent.gr_mem = list (grpfields[3]);
+	grent.gr_mem = list(fields[3]);
 	if (NULL == grent.gr_mem) {
 		return NULL;	/* out of memory */
 	}
 
 	return &grent;
 }
-
diff --git a/lib/sgetpwent.c b/lib/sgetpwent.c
index 691979a19..7ece4dccb 100644
--- a/lib/sgetpwent.c
+++ b/lib/sgetpwent.c
@@ -44,9 +44,10 @@ sgetpwent(const char *s)
 {
 	static char          *dup = NULL;
 	static struct passwd pwent;
+
 	int i;
 	char *cp;
-	char *fields[NFIELDS];
+	char  *fields[NFIELDS];
 
 	free(dup);
 	dup = strdup(s);
diff --git a/lib/sgetspent.c b/lib/sgetspent.c
index e2d247d82..8a19e8d82 100644
--- a/lib/sgetspent.c
+++ b/lib/sgetspent.c
@@ -41,6 +41,7 @@ sgetspent(const char *s)
 {
 	static char        *dup = NULL;
 	static struct spwd spwd;
+
 	char *fields[FIELDS];
 	char *cp;
 	int i;